On Fri, 16 Feb 2024 17:37:23 +0100
Daniel Vetter <daniel@xxxxxxxx> wrote:
> > > @@ -1503,6 +1504,24 @@ int drm_mode_atomic_ioctl(struct drm_device *dev,
> > > drm_mode_object_put(obj);
> > > }
> > >
> > > + if (trace_drm_mode_atomic_commit_enabled()) {
> > > + struct drm_crtc_state *crtc_state;
> > > + struct drm_crtc *crtc;
> > > + int *crtcs;
> > > + int i, num_crtcs;
> > > +
> > > + crtcs = kcalloc(dev->mode_config.num_crtc, sizeof(int),
> > > + GFP_KERNEL);
> >
> > If the above allocation fails, this will cause a NULL kernel dereference.
>
> Yeah can't we somehow iterate directly into the trace subsystem? If
> nothing else works I guess just a per-crtc event should do.
You mean like this?
https://lore.kernel.org/all/20240216105934.7b81eae9@xxxxxxxxxxxxxxxxxx/
;-)
-- Steve
