[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 0b48b36f80b0 -> drm/amdgpu: Need to resume ras during gpu reset for gfx v9_4_3 sriov) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler <daniel.wheeler@xxxxxxx> Thank you, Dan Wheeler Sr. Technologist | AMD SW Display ------------------------------------------------------------------------------------------------------------------ 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -----Original Message----- From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Hamza Mahfooz Sent: Wednesday, January 31, 2024 3:11 PM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Chung, ChiaHsuan (Tom) <ChiaHsuan.Chung@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Li, Roman <Roman.Li@xxxxxxx>; Zuo, Jerry <Jerry.Zuo@xxxxxxx>; Pillai, Aurabindo <Aurabindo.Pillai@xxxxxxx>; Wu, Hersen <hersenxs.wu@xxxxxxx>; Mahfooz, Hamza <Hamza.Mahfooz@xxxxxxx>; Lin, Wayne <Wayne.Lin@xxxxxxx>; Wentland, Harry <Harry.Wentland@xxxxxxx>; Gutierrez, Agustin <Agustin.Gutierrez@xxxxxxx> Subject: [PATCH 00/21] DC Patches January 31, 2024 This version brings along the following: * DCN35 fixes * DMUB fixes * Link training fixes * Misc code style fixes * MST fixes * ODM fixes * SubVP fixes Allen Pan (1): drm/amd/display: correct static screen event mask Alvin Lee (2): Revert "drm/amd/display: For FPO and SubVP/DRR configs program vmin/max sel" drm/amd/display: Update phantom pipe enable / disable sequence Aric Cyr (1): drm/amd/display: 3.2.271 Camille Cho (1): drm/amd/display: correct comment in set_default_brightness_aux() Ethan Bitnun (2): drm/amd/display: Add delay before logging clks from hw drm/amd/display: Adjust set_p_state calls to fix logging Fangzhi Zuo (1): drm/amd/display: Fix MST Null Ptr for RV George Shen (2): drm/amd/display: Add debug option to force 1-tap chroma subsampling drm/amd/display: Add left edge pixel for YCbCr422/420 + ODM pipe split Michael Strauss (2): drm/amd/display: Remove Legacy FIXED_VS Transparent LT Sequence drm/amd/display: Don't perform rate toggle on DP2-capable FIXED_VS retimers Nicholas Kazlauskas (4): drm/amd/display: Add more checks for exiting idle in DC drm/amd/display: Disable timeout in more places for dc_dmub_srv drm/amd/display: Increase eval/entry delay for DCN35 drm/amd/display: Disable idle reallow as part of command/gpint execution Rodrigo Siqueira (4): drm/amd/display: Drop legacy code drm/amd/display: Disable ODM by default for DCN35 drm/amd/display: Trivial code style adjustment drm/amd/display: Drop some unnecessary guards Wenjing Liu (1): drm/amd/display: set odm_combine_policy based on context in dcn32 resource .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 +- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 2 - .../dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c | 4 - .../display/dc/clk_mgr/dcn301/dcn301_smu.c | 4 - .../amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 4 - .../display/dc/clk_mgr/dcn314/dcn314_smu.c | 6 - .../display/dc/clk_mgr/dcn315/dcn315_smu.c | 4 - .../display/dc/clk_mgr/dcn316/dcn316_smu.c | 4 - .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 2 + .../dc/clk_mgr/dcn32/dcn32_clk_mgr_smu_msg.h | 3 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 115 +++--- .../gpu/drm/amd/display/dc/core/dc_resource.c | 68 ++-- .../gpu/drm/amd/display/dc/core/dc_stream.c | 18 + .../gpu/drm/amd/display/dc/core/dc_surface.c | 2 + drivers/gpu/drm/amd/display/dc/dc.h | 9 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 17 +- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 2 - drivers/gpu/drm/amd/display/dc/dc_stream.h | 2 + .../gpu/drm/amd/display/dc/dcn10/dcn10_opp.c | 7 + .../display/dc/dcn32/dcn32_resource_helpers.c | 14 + drivers/gpu/drm/amd/display/dc/dm_cp_psp.h | 3 + .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 26 +- .../amd/display/dc/hwss/dce110/dce110_hwseq.c | 4 +- .../amd/display/dc/hwss/dce110/dce110_hwseq.h | 4 + .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 2 +- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 17 +- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.h | 4 + .../amd/display/dc/hwss/dcn31/dcn31_hwseq.c | 2 - .../amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 76 +++- .../amd/display/dc/hwss/dcn32/dcn32_hwseq.h | 2 + .../amd/display/dc/hwss/dcn32/dcn32_init.c | 3 + .../amd/display/dc/hwss/dcn35/dcn35_hwseq.c | 21 +- .../amd/display/dc/hwss/dcn35/dcn35_hwseq.h | 3 + .../amd/display/dc/hwss/dcn35/dcn35_init.c | 2 +- .../amd/display/dc/hwss/dcn351/dcn351_init.c | 2 +- .../drm/amd/display/dc/hwss/hw_sequencer.h | 1 + .../display/dc/hwss/hw_sequencer_private.h | 9 +- .../gpu/drm/amd/display/dc/inc/core_types.h | 2 + drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h | 2 - .../amd/display/dc/inc/hw/timing_generator.h | 2 - drivers/gpu/drm/amd/display/dc/inc/resource.h | 27 +- .../drm/amd/display/dc/link/link_validation.c | 2 - .../dc/link/protocols/link_dp_training.c | 5 +- .../link_dp_training_fixed_vs_pe_retimer.c | 372 +----------------- .../link_dp_training_fixed_vs_pe_retimer.h | 5 - .../link/protocols/link_edp_panel_control.c | 2 +- .../dc/resource/dcn31/dcn31_resource.c | 2 - .../dc/resource/dcn32/dcn32_resource.c | 18 +- .../dc/resource/dcn32/dcn32_resource.h | 3 + .../dc/resource/dcn321/dcn321_resource.c | 2 +- .../dc/resource/dcn35/dcn35_resource.c | 6 +- drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 1 - .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 11 - .../gpu/drm/amd/display/dmub/src/dmub_dcn32.c | 2 - 54 files changed, 372 insertions(+), 572 deletions(-) -- 2.43.0