I only noticed this because my distro broke the mec2.bin symbolic link, so the firmware failed to load. This resulted in: amdgpu 0000:0b:00.0: Direct firmware load for amdgpu/navi10_mec2.bin failed with error -2 BUG: kernel NULL pointer dereference, address: 0000000000000008 [...] Call Trace: <TASK> ? __die+0x23/0x70 ? page_fault_oops+0x17d/0x4b0 ? srso_alias_return_thunk+0x5/0xfbef5 ? exc_page_fault+0x72/0x160 ? asm_exc_page_fault+0x26/0x30 ? request_firmware+0x48/0x60 [firmware_class] ? amdgpu_gfx_cp_init_microcode+0x22e/0x260 [amdgpu] gfx_v10_0_early_init+0x722/0x8d0 [amdgpu] The attached patch removes some code that looks like it was added by mistake, or by a bad merge. With it I get still get the load failed error as expected, but no crash. After fixing the firmware, no error is printed. David McFarland (1): drm/amd: Don't init MEC2 firmware when it fails to load drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 -- 1 file changed, 2 deletions(-) -- 2.40.1
