[AMD Official Use Only - General]
The patch is
Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>
BTW, we could take further step to retire the if branch (bypass == 1) with proper RAS_TA changes on legacy Vega20/Arcturus
if (bypass) {
if (__amdgpu_ras_feature_enable(adev, &obj->head, 0))
break;
}
Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Tao Zhou
Sent: Monday, January 29, 2024 11:54
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Zhou1, Tao <Tao.Zhou1@xxxxxxx>
Subject: [PATCH] drm/amdgpu: disable ras feature when fini
Send ras disable feature command in fini.
Signed-off-by: Tao Zhou <tao.zhou1@xxxxxxx>
Change-Id: I95f1d1e0a46fb613631e5cd77497e64c0551c4c7
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index a249f24ed038..a9fa2d134670 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -3437,7 +3437,7 @@ int amdgpu_ras_fini(struct amdgpu_device *adev)
WARN(AMDGPU_RAS_GET_FEATURES(con->features), "Feature mask is not cleared");
if (AMDGPU_RAS_GET_FEATURES(con->features))
- amdgpu_ras_disable_all_features(adev, 1);
+ amdgpu_ras_disable_all_features(adev, 0);
cancel_delayed_work_sync(&con->ras_counte_delay_work);
--
2.34.1
