[PATCH] drm/amdgpu: fix coding style and printing in amdgpu_doorbell_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net>

On 03/07/2017 12:54 AM, Christian König wrote:
> From: Christian König <christian.koenig at amd.com>
> 
> Based on commit "drm/radeon: remove useless and potentially wrong message".
> 
> The size of the info printing is incorrect and the PCI subsystems prints
> the same info on boot anyway.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index bf31aaf..fd03072 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -381,12 +381,11 @@ static int amdgpu_doorbell_init(struct amdgpu_device *adev)
>  	if (adev->doorbell.num_doorbells == 0)
>  		return -EINVAL;
>  
> -	adev->doorbell.ptr = ioremap(adev->doorbell.base, adev->doorbell.num_doorbells * sizeof(u32));
> -	if (adev->doorbell.ptr == NULL) {
> +	adev->doorbell.ptr = ioremap(adev->doorbell.base,
> +				     adev->doorbell.num_doorbells *
> +				     sizeof(u32));
> +	if (adev->doorbell.ptr == NULL)
>  		return -ENOMEM;
> -	}
> -	DRM_INFO("doorbell mmio base: 0x%08X\n", (uint32_t)adev->doorbell.base);
> -	DRM_INFO("doorbell mmio size: %u\n", (unsigned)adev->doorbell.size);
>  
>  	return 0;
>  }
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170307/1eb318a4/attachment.sig>


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux