[AMD Official Use Only - General]
Reviewed-by: Tao Zhou <tao.zhou1@xxxxxxx>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Srinivasan
> Shanmugam
> Sent: Tuesday, December 19, 2023 10:12 PM
> To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian
> <Christian.Koenig@xxxxxxx>
> Cc: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@xxxxxxx>; amd-
> gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH] drm/amdgpu: Use kzalloc instead of kmalloc+__GFP_ZERO in
> amdgpu_ras.c
>
> Fixes the below smatch warnings:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2543 amdgpu_ras_recovery_init()
> warn: Please consider using kzalloc instead of kmalloc
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2830 amdgpu_ras_init() warn:
> Please consider using kzalloc instead of kmalloc
>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index bad62141f708..e541e6925918 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -2540,7 +2540,7 @@ int amdgpu_ras_recovery_init(struct amdgpu_device
> *adev)
> return 0;
>
> data = &con->eh_data;
> - *data = kmalloc(sizeof(**data), GFP_KERNEL | __GFP_ZERO);
> + *data = kzalloc(sizeof(**data), GFP_KERNEL);
> if (!*data) {
> ret = -ENOMEM;
> goto out;
> @@ -2827,10 +2827,10 @@ int amdgpu_ras_init(struct amdgpu_device *adev)
> if (con)
> return 0;
>
> - con = kmalloc(sizeof(struct amdgpu_ras) +
> + con = kzalloc(sizeof(*con) +
> sizeof(struct ras_manager) *
> AMDGPU_RAS_BLOCK_COUNT +
> sizeof(struct ras_manager) *
> AMDGPU_RAS_MCA_BLOCK_COUNT,
> - GFP_KERNEL|__GFP_ZERO);
> + GFP_KERNEL);
> if (!con)
> return -ENOMEM;
>
> --
> 2.34.1
<<attachment: winmail.dat>>
