On Sat, Nov 18, 2023 at 01:32:34PM -0600, Yazen Ghannam wrote:
> +/* GPU UMCs have MCATYPE=0x1.*/
> +bool smca_gpu_umc_bank_type(u64 ipid)
> +{
> + if (!smca_umc_bank_type(ipid))
> + return false;
> +
> + return FIELD_GET(MCI_IPID_MCATYPE, ipid) == 0x1;
> +}
And now this tells you that you want to use
u32 hwid_mcatype; /* (hwid,mcatype) tuple */
everywhere and do your macros around that thing.
No need for yet another helper as this all is static information which
doesn't change.
> +EXPORT_SYMBOL_GPL(smca_gpu_umc_bank_type);
Definitely not another export.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
