Hi David, On 1 March 2017 at 07:09, zhoucm1 <david1.zhou at amd.com> wrote: >>> + ctx->priority = priority; >> >> seems not used. > > I see ctx->priority is used in following patches, so pls remove it there. > Fwiw, I don't think that's a good idea. Most places in the kernel are OK if you add plumbing with patch X and use it with X+1. Moving things there will make for a big patch that is harder/more annoying to review properly. IMHO it's perfectly fine to add a note in the commit message - "currently prio is propagated through the driver and the next commit(s) will make use of it", right ? -Emil
