[Public]
Hi all,
This week this patchset was tested on the following systems:
• Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U
• MSI Gaming X Trio RX 6800
• Gigabyte Gaming OC RX 7900 XTX
These systems were tested on the following display/connection types:
• eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U])
• VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI])
• DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters])
• Thunderbolt (LG Ultrafine 5k)
• MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays)
• DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display)
• USB 4 (Kensington SD5700T and 1x 4k 60Hz display)
• PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports])
The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to):
• Changing display configurations and settings
• Benchmark testing
• Feature testing (Freesync, etc.)
Automated testing includes (but is not limited to):
• Script testing (scripts to automate some of the manual checks)
• IGT testing
The patchset consists of the amd-staging-drm-next branch (Head commit 2ca13e7462d5 drm/amd/display: Promote DC to 3.2.260) with new patches added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler <daniel.wheeler@xxxxxxx>
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
------------------------------------------------------------------------------------------------------------------
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.com
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Hamza Mahfooz
Sent: Wednesday, November 15, 2023 2:40 PM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Wang, Chao-kai (Stylon) <Stylon.Wang@xxxxxxx>; Chung, ChiaHsuan (Tom) <ChiaHsuan.Chung@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Li, Roman <Roman.Li@xxxxxxx>; Zuo, Jerry <Jerry.Zuo@xxxxxxx>; Pillai, Aurabindo <Aurabindo.Pillai@xxxxxxx>; Wu, Hersen <hersenxs.wu@xxxxxxx>; Mahfooz, Hamza <Hamza.Mahfooz@xxxxxxx>; Lin, Wayne <Wayne.Lin@xxxxxxx>; Wentland, Harry <Harry.Wentland@xxxxxxx>; Gutierrez, Agustin <Agustin.Gutierrez@xxxxxxx>
Subject: [PATCH 00/35] DC Patches November 15, 2023
This DC patchset brings improvements in multiple areas. In summary, we
highlight:
* DCN314 fixes
* DCN32 fixes
* DCN35 fixes
* DML2 fixes
* eDP fixes
* HDR fixes
* MST fixes
* Replay fixes
* SubVP support for more configs
Alvin Lee (5):
drm/amd/display: Include udelay when waiting for INBOX0 ACK
drm/amd/display: Use DRAM speed from validation for dummy p-state
drm/amd/display: Increase num voltage states to 40
drm/amd/display: Enable SubVP on 1080p60 displays
drm/amd/display: If P-State is supported try SubVP for smaller vlevel
Anthony Koo (1):
drm/amd/display: [FW Promotion] Release 0.0.193.0
Aric Cyr (1):
drm/amd/display: 3.2.261
Bhuvana Chandra Pinninti (1):
drm/amd/display: Refactor DSC into component folder
Camille Cho (1):
drm/amd/display: Simplify brightness initialization
Dennis Chan (2):
drm/amd/display: Add new Replay command and Disabled Replay Timing
Reysnc
drm/amd/display: Disable Timing sync check in Full-Screen Video Case
Gabe Teeger (1):
Revert "drm/amd/display: Enable CM low mem power optimization"
Ian Chen (1):
drm/amd/display: add skip_implict_edp_power_control flag for dce110
Ilya Bakoulin (1):
drm/amd/display: Fix MPCC 1DLUT programming
Max Tseng (2):
drm/amd/display: replay: generalize the send command function usage
drm/amd/display: replay: Augment Frameupdate Command
Meenakshikumar Somasundaram (1):
drm/amd/display: Fix tiled display misalignment
Michael Strauss (1):
drm/amd/display: Do not read DPREFCLK spread info from LUT on DCN35
Nicholas Kazlauskas (7):
drm/amd/display: Add z-state support policy for dcn35
drm/amd/display: Update DCN35 watermarks
drm/amd/display: Add Z8 watermarks for DML2 bbox overrides
drm/amd/display: Feed SR and Z8 watermarks into DML2 for DCN35
drm/amd/display: Remove min_dst_y_next_start check for Z8
drm/amd/display: Update min Z8 residency time to 2100 for DCN314
drm/amd/display: Update DCN35 clock table policy
Parandhaman K (1):
drm/amd/display: Refactor OPTC into component folder
Sung Joon Kim (1):
drm/amd/display: Fix black screen on video playback with embedded
panel
Taimur Hassan (3):
drm/amd/display: Remove config update
drm/amd/display: Fix conversions between bytes and KB
drm/amd/display: Fix some HostVM parameters in DML
Wayne Lin (1):
drm/amd/display: adjust flow for deallocation mst payload
Wenjing Liu (3):
drm/amd/display: fix a pipe mapping error in dcn32_fpu
drm/amd/display: update pixel clock params after stream slice count
change in context
drm/amd/display: always use mpc factor of 2 for stereo timings
Zhongwei (1):
drm/amd/display: force toggle rate wa for first link training for a
retimer
drivers/gpu/drm/amd/display/Makefile | 2 +
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 53 ++++---
drivers/gpu/drm/amd/display/dc/Makefile | 2 +-
.../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 132 +++++++++---------
drivers/gpu/drm/amd/display/dc/core/dc.c | 4 +
.../gpu/drm/amd/display/dc/core/dc_resource.c | 11 +-
drivers/gpu/drm/amd/display/dc/dc.h | 5 +-
drivers/gpu/drm/amd/display/dc/dc_types.h | 82 ++++++++---
.../gpu/drm/amd/display/dc/dce/dmub_replay.h | 2 +
drivers/gpu/drm/amd/display/dc/dcn10/Makefile | 2 +-
.../dc/dcn10/dcn10_hw_sequencer_debug.c | 2 +-
drivers/gpu/drm/amd/display/dc/dcn20/Makefile | 4 +-
.../gpu/drm/amd/display/dc/dcn201/Makefile | 2 +-
drivers/gpu/drm/amd/display/dc/dcn30/Makefile | 1 -
.../gpu/drm/amd/display/dc/dcn301/Makefile | 3 +-
drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 2 +-
.../gpu/drm/amd/display/dc/dcn314/Makefile | 2 +-
drivers/gpu/drm/amd/display/dc/dcn32/Makefile | 6 +-
.../gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 13 +- .../display/dc/dcn32/dcn32_resource_helpers.c | 32 ++++-
drivers/gpu/drm/amd/display/dc/dcn35/Makefile | 4 +-
.../drm/amd/display/dc/dcn35/dcn35_pg_cntl.c | 10 ++
drivers/gpu/drm/amd/display/dc/dm_helpers.h | 12 +-
.../gpu/drm/amd/display/dc/dml/dc_features.h | 2 +-
.../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 15 +- .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 78 ++++++----- .../drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 82 ++++++++++-
.../drm/amd/display/dc/dml/dcn35/dcn35_fpu.h | 2 +
.../amd/display/dc/dml2/display_mode_core.c | 18 +--
.../display/dc/dml2/dml2_dc_resource_mgmt.c | 26 ++--
.../display/dc/dml2/dml2_translation_helper.c | 60 +++++---
.../gpu/drm/amd/display/dc/dml2/dml2_utils.c | 2 +-
.../gpu/drm/amd/display/dc/dml2/dml2_utils.h | 2 +-
.../drm/amd/display/dc/dml2/dml2_wrapper.h | 2 +
drivers/gpu/drm/amd/display/dc/dsc/Makefile | 26 ++++
.../display/dc/{ => dsc}/dcn20/dcn20_dsc.c | 0
.../display/dc/{ => dsc}/dcn20/dcn20_dsc.h | 0
.../display/dc/{ => dsc}/dcn35/dcn35_dsc.c | 0
.../display/dc/{ => dsc}/dcn35/dcn35_dsc.h | 0
.../drm/amd/display/dc/{inc/hw => dsc}/dsc.h | 0
.../amd/display/dc/hwss/dce110/dce110_hwseq.c | 3 +-
.../amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 6 +-
.../gpu/drm/amd/display/dc/inc/core_types.h | 1 +
drivers/gpu/drm/amd/display/dc/inc/link.h | 3 +
.../drm/amd/display/dc/link/link_detection.c | 2 +-
.../gpu/drm/amd/display/dc/link/link_dpms.c | 108 ++------------
.../drm/amd/display/dc/link/link_factory.c | 1 +
.../link_dp_training_fixed_vs_pe_retimer.c | 6 +-
.../link/protocols/link_edp_panel_control.c | 46 ++++--
.../link/protocols/link_edp_panel_control.h | 4 +-
drivers/gpu/drm/amd/display/dc/optc/Makefile | 108 ++++++++++++++
.../display/dc/{ => optc}/dcn10/dcn10_optc.c | 0
.../display/dc/{ => optc}/dcn10/dcn10_optc.h | 0
.../display/dc/{ => optc}/dcn20/dcn20_optc.c | 0
.../display/dc/{ => optc}/dcn20/dcn20_optc.h | 2 +-
.../dc/{ => optc}/dcn201/dcn201_optc.c | 0
.../dc/{ => optc}/dcn201/dcn201_optc.h | 0
.../display/dc/{ => optc}/dcn30/dcn30_optc.c | 0
.../display/dc/{ => optc}/dcn30/dcn30_optc.h | 0
.../dc/{ => optc}/dcn301/dcn301_optc.c | 0
.../dc/{ => optc}/dcn301/dcn301_optc.h | 0
.../display/dc/{ => optc}/dcn31/dcn31_optc.c | 0
.../display/dc/{ => optc}/dcn31/dcn31_optc.h | 0
.../dc/{ => optc}/dcn314/dcn314_optc.c | 0
.../dc/{ => optc}/dcn314/dcn314_optc.h | 0
.../display/dc/{ => optc}/dcn32/dcn32_optc.c | 0
.../display/dc/{ => optc}/dcn32/dcn32_optc.h | 0
.../display/dc/{ => optc}/dcn35/dcn35_optc.c | 0
.../display/dc/{ => optc}/dcn35/dcn35_optc.h | 0
.../dc/resource/dcn20/dcn20_resource.c | 16 ++-
.../dc/resource/dcn20/dcn20_resource.h | 1 +
.../dc/resource/dcn314/dcn314_resource.c | 2 +-
.../dc/resource/dcn32/dcn32_resource.c | 1 +
.../dc/resource/dcn32/dcn32_resource.h | 10 ++
.../dc/resource/dcn321/dcn321_resource.c | 1 +
.../dc/resource/dcn35/dcn35_resource.c | 11 +-
.../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 80 ++++++++++-
.../gpu/drm/amd/display/dmub/src/dmub_srv.c | 1 +
79 files changed, 742 insertions(+), 391 deletions(-) rename drivers/gpu/drm/amd/display/dc/{ => dsc}/dcn20/dcn20_dsc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => dsc}/dcn20/dcn20_dsc.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => dsc}/dcn35/dcn35_dsc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => dsc}/dcn35/dcn35_dsc.h (100%) rename drivers/gpu/drm/amd/display/dc/{inc/hw => dsc}/dsc.h (100%) create mode 100644 drivers/gpu/drm/amd/display/dc/optc/Makefile
rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn10/dcn10_optc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn10/dcn10_optc.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn20/dcn20_optc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn20/dcn20_optc.h (99%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn201/dcn201_optc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn201/dcn201_optc.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn30/dcn30_optc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn30/dcn30_optc.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn301/dcn301_optc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn301/dcn301_optc.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn31/dcn31_optc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn31/dcn31_optc.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn314/dcn314_optc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn314/dcn314_optc.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn32/dcn32_optc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn32/dcn32_optc.h (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn35/dcn35_optc.c (100%) rename drivers/gpu/drm/amd/display/dc/{ => optc}/dcn35/dcn35_optc.h (100%)
--
2.42.0
