RE: [PATCH] drm/amdgpu: fix mca ipid socketid decode issue

["Zhang, Hawking" <Hawking.Zhang@xxxxxxx>]

[AMD Official Use Only - General]

Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>

Regards,
Hawking
-----Original Message-----
From: Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>
Sent: Wednesday, November 15, 2023 07:59
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>
Subject: [PATCH] drm/amdgpu: fix mca ipid socketid decode issue

Fix mca ipid socket id decode issue

Fixes: 610259215805 ("drm/amdgpu: correct mca ipid die/socket/addr decode")

Signed-off-by: Yang Wang <kevinyang.wang@xxxxxxx>
---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index 6daa8ee49035..d4e312003181 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -2410,7 +2410,7 @@ static void mca_bank_entry_info_decode(struct mca_bank_entry *entry, struct mca_
        instidhi = REG_GET_FIELD(ipid, MCMP1_IPIDT0, InstanceIdHi);
        instid = REG_GET_FIELD(ipid, MCMP1_IPIDT0, InstanceIdLo);
        info->aid = ((instidhi >> 2) & 0x03);
-       info->socket_id = ((instid & 0x1) << 4) | (instidhi & 0x03);
+       info->socket_id = ((instid & 0x1) << 2) | (instidhi & 0x03);
 }

 static int mca_bank_read_reg(struct amdgpu_device *adev, enum amdgpu_mca_error_type type,
--
2.34.1