Re: [PATCH 1/2] drm/amd/pm: Update metric table for smu v13_0_6

["Lazar, Lijo" <lijo.lazar@xxxxxxx>]

On 11/14/2023 2:25 PM, Asad Kamal wrote:
> Update pmfw metric table to include pcie
> instantaneous bandwidth & pcie error counters
>
> Signed-off-by: Asad Kamal <asad.kamal@xxxxxxx>
> Reviewed-by: Le Ma <le.ma@xxxxxxx>

Series is -
	Reviewed-by: Lijo Lazar <lijo.lazar@xxxxxxx>

Thanks,
Lijo

> ---
>   .../drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h    | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h
> index dab35d878a90..fef2d290f3f2 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h
> +++ b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h
> @@ -123,7 +123,7 @@ typedef enum {
>     VOLTAGE_GUARDBAND_COUNT
>   } GFX_GUARDBAND_e;
>   
> -#define SMU_METRICS_TABLE_VERSION 0x8
> +#define SMU_METRICS_TABLE_VERSION 0x9
>   
>   typedef struct __attribute__((packed, aligned(4))) {
>     uint32_t AccumulationCounter;
> @@ -211,6 +211,14 @@ typedef struct __attribute__((packed, aligned(4))) {
>     //XGMI Data tranfser size
>     uint64_t XgmiReadDataSizeAcc[8];//in KByte
>     uint64_t XgmiWriteDataSizeAcc[8];//in KByte
> +
> +  //PCIE BW Data and error count
> +  uint32_t PcieBandwidth[4];
> +  uint32_t PCIeL0ToRecoveryCountAcc;      // The Pcie counter itself is accumulated
> +  uint32_t PCIenReplayAAcc;               // The Pcie counter itself is accumulated
> +  uint32_t PCIenReplayARolloverCountAcc;  // The Pcie counter itself is accumulated
> +  uint32_t PCIeNAKSentCountAcc;           // The Pcie counter itself is accumulated
> +  uint32_t PCIeNAKReceivedCountAcc;       // The Pcie counter itself is accumulated
>   } MetricsTable_t;
>   
>   #define SMU_VF_METRICS_TABLE_VERSION 0x3