On 2023-10-30 15:54, Aurabindo Pillai wrote:
On 10/29/2023 5:39 AM, José Pekkarinen wrote:
Spotted by coccicheck, there is a redundant check for
v->SourcePixelFormat[k] != dm_444_16. This patch will
remove it. The corresponding output follows.
drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c:5130:86-122:
duplicated argument to && or ||
Signed-off-by: José Pekkarinen <jose.pekkarinen@xxxxxxxxxxx>
---
drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 2
+-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
index ad741a723c0e..3686f1e7de3a 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
@@ -5128,7 +5128,7 @@ void
dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib
*mode_l
ViewportExceedsSurface = true;
if (v->SourcePixelFormat[k] != dm_444_64 &&
v->SourcePixelFormat[k] != dm_444_32 && v->SourcePixelFormat[k] !=
dm_444_16
- && v->SourcePixelFormat[k] != dm_444_16 &&
v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] !=
dm_rgbe) {
+ && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k]
!= dm_rgbe) {
if (v->ViewportWidthChroma[k] > v->SurfaceWidthC[k] ||
v->ViewportHeightChroma[k] > v->SurfaceHeightC[k]) {
ViewportExceedsSurface = true;
}
Thanks for catching.
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>
Sorry to bring this up, I just wanted to check whether this
has been applied in the following pulls or not.
Thanks!
José.
