-----Original Message----- From: Mark Brown [mailto:broonie@xxxxxxxxxx] Sent: Wednesday, June 28, 2017 11:36 PM To: Alex Deucher Cc: dri-devel at lists.freedesktop.org; amd-gfx at lists.freedesktop.org; alsa-devel at alsa-project.org; airlied at gmail.com; Mukunda, Vijendar; rajeevkumar.linux at gmail.com; lgirdwood at gmail.com; tiwai at suse.de; perex at perex.cz; Deucher, Alexander Subject: Re: [PATCH 4/8] ASoC: AMD: added condition checks for CZ specific code On Fri, Jun 23, 2017 at 12:35:02PM -0400, Alex Deucher wrote: > Reviewed-by: Alex Deucher <alexander.deucher at amd.com> > index dcbf997..e48ae5d 100644 > --- a/sound/soc/amd/acp-pcm-dma.c > +++ b/sound/soc/amd/acp-pcm-dma.c > @@ -34,6 +34,8 @@ > > #define MAX_BUFFER (PLAYBACK_MAX_PERIOD_SIZE * > PLAYBACK_MAX_NUM_PERIODS) #define MIN_BUFFER MAX_BUFFER > +#define CHIP_STONEY 14 > +#define CHIP_CARRIZO 13 >These defines are being added in the middle of a file but CHIP_STONEY is also used in another file in the previous patch (and apparently extensively throughout the DRM driver already). This is obviously not good, >we shouldn't have multiple copies of the definition. > - } else { > + if (adata->asic_type == CHIP_CARRIZO) { > + for (bank = 1; bank <= 4; bank++) > + acp_set_sram_bank_state(adata->acp_mmio, bank, > + false); > I'm not seeing any poweroff cases for other chips being added, and again switch statements please. We will modify code to use single definition for CHIP_STONEY and CHIP_CARRIZO. There are only two chip sets based on ACP 2.x design(Carrizo and Stoney). Our future Chip sets going to use different design based on next ACP IP version. In the current patch, Condition checks added for Carrizo for setting SRAM BANK state. Memory Gating is disabled in Stoney,i.e SRAM Bank's won't be turned off. The default state for SRAM banks is ON. As Memory Gating is disabled, there is no need to add condition checks for Stoney to set SRAM Bank state. Apart from Memory Gating, there are few more differences between Stoney and Carrizo chip sets. Stoney specific DMA driver changes submitted in a separate patch. Vijendar
