On 28/06/17 11:33 AM, John Brooks wrote: > Changes in this version: > - Dropped former patch 1 ("Separate placements and busy placements") as it was > no longer necessary > - Dropped former patch 4 ("Don't force BOs into visible VRAM if they can go to > GTT instead") as it was unnecessary and had too many side effects (Thanks > Christian) > - Dropped former patches 8 and 9 ("Asynchronously move BOs to visible VRAM" and > an associated optimization), as there may be better ways to address the root > of the problem > - Added a u64 cast to patch 1 (Thanks Christian) > - Optimized patch 2 in the case where visible VRAM is not smaller than total > VRAM (Thanks Michel) > > The series as it is now fixes Dying Light and improves DiRT Rally frame times. > Without the asynchronous moves, there is still occasional stalling in DiRT > Rally. > > > The "Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS" patch received > objections, but I have not removed it yet as there seems to be some support for > the idea. The precise details of when to set and clear the flag may need further > discussion. Have you tried my idea of only clearing the flag when a BO is moved to VRAM? If that works well enough, patch 3 should not be necessary either. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer