On 15/06/17 04:42 PM, Emil Velikov wrote: > On 15 June 2017 at 04:16, Michel Dänzer <michel at daenzer.net> wrote: >> On 14/06/17 08:34 PM, Emil Velikov wrote: >> >>> Personally I would not have bothered with the table_max_size thing >> >> It seemed silly to reallocate the memory in the default case where the >> amdgpu.ids file from this repository is used. :) >> > Agreed. Yet the single, "reduce memory consumption" realloc seems to > diminish amongst the ~150 [unneeded] strdup/free, in parse_one_line > </tease> True. >>> or the separate Makefile. >> >> You mean data/Makefile.am? What would you have done instead? >> > One can fold the two lines within the top makefile (see below) since > I'm lazy to complete the "use non-recursive makefiles" [1] branch. > > -Emil > [1] https://github.com/evelikov/libdrm/commits/hello-world > > --- a/Makefile.am > +++ b/Makefile.am > @@ -43,6 +43,9 @@ AM_DISTCHECK_CONFIGURE_FLAGS = \ > --enable-manpages \ > --enable-valgrind > > +libdrmdatadir = @libdrmdatadir@ > +dist_libdrmdata_DATA = data/amdgpu.ids > + > pkgconfigdir = @pkgconfigdir@ > pkgconfig_DATA = libdrm.pc Thanks. I'm afraid I don't care enough right now, but maybe somebody else can pick up your suggestions. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
