On 2017-06-05 03:48 PM, Xie, AlexBin wrote: > Hi Andres, > > I think the original patch was written by you. Would you comment? Is it a bug or intentional? > > Thank you. > > Alex Bin Xie > > > Message: 1 > Date: Mon, 5 Jun 2017 10:36:59 -0400 > From: Tom St Denis <tom.stdenis at amd.com> > To: amd-gfx at lists.freedesktop.org > Subject: Re: amd-gfx Digest, Vol 13, Issue 29 > Message-ID: <58773ac0-93a7-e494-d447-88e93ded999c at amd.com> > Content-Type: text/plain; charset=utf-8; format=flowed > > On 05/06/17 10:24 AM, Xie, AlexBin wrote: >> Hi, Tom, >> >> You have found a bug. >> >> Your patch looks fine for me. >> >> Have you confirmed the deleted part is older version? Perhaps search email list or git history to confirm? > > It looks like the edits to the older GFX files (7/8) simply changed that > block of code whereas the gfx9 version they pasted in the fixed block > moving the old block down. Yeah there was a problem with the rebase here. Tom/Alex's fix on the mailing list is the intended solution. Regards, Andres > > Tom > > > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx >