[PATCH 1/5] drm/amdgpu/sdma4: drop unused register header

deathsimple@xxxxxxxxxxx (Christian König) · Fri, 28 Jul 2017 10:56:51 +0200

Am 27.07.2017 um 21:46 schrieb Alex Deucher:
> nbio registers are not used in this file.
>
> Cc: Frank Min <Frank.Min at amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Patches #1 and #3-#5 are Reviewed-by: Christian KÃ¶nig 
<christian.koenig at amd.com>.

I agree with Felix that #2 looks a bit ugly, but using writeq doesn't 
sounds like the correct answer either.

If WRITE_ONCE() does the job then I would use that one.

Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index 5c24708..7cb5320 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -35,7 +35,6 @@
>   #include "vega10/MMHUB/mmhub_1_0_offset.h"
>   #include "vega10/MMHUB/mmhub_1_0_sh_mask.h"
>   #include "vega10/HDP/hdp_4_0_offset.h"
> -#include "vega10/NBIO/nbio_6_1_offset.h"
>   #include "raven1/SDMA0/sdma0_4_1_default.h"
>   
>   #include "soc15_common.h"