[PATCH 1/2] drm: Implement vm_operations_struct.access

[felix.kuehling@xxxxxxx (Felix Kuehling)]

On 17-07-14 06:06 AM, Christian König wrote:
> Am 13.07.2017 um 23:08 schrieb Felix Kuehling:
>> Allows gdb to access contents of user mode mapped BOs. VRAM access
>> requires the driver to implement a new callback in ttm_bo_driver.
>
> One more comment additionally to what Michel already wrote below,
> apart from that it looks good to me.
>
>>
>> +    switch(bo->mem.mem_type) {
>> +    case TTM_PL_SYSTEM:
>
> When the BO is in the system domain you need to add this as well I think:
>
>         if (unlikely(bo->ttm->page_flags & TTM_PAGE_FLAG_SWAPPED)) {
>                 ret = ttm_tt_swapin(bo->ttm);
>                 if (unlikely(ret != 0))
>                         return ret;
>         }

OK, thanks for pointing that out.

Regards,
  Felix

>
> Regards,
> Christian.