On Tue, Jul 04, 2017 at 05:39:51PM +0800, Zhang, Jerry wrote: > Hi Ray, > > Thanks for your initial patch to enable PSP option for Raven. > > To simplify it, we may leverage VEGA10 case for Raven directly. > And remove all Raven existing code under "case CHIP_RAVEN" > How do you think about it? > Probably not. Vega10 enabled psp fw loading by default, but not for raven. My mainly idea here is default: modprobe amdgpu -> use direct fw loading. debugging psp: modprobe amdgpu fw_load_type=2 -> use psp fw loading. It doesn't impact other guys use and we can debug it more smoothly. :-) Thanks, Ray
