Hi Xie,
Perhaps you want to use `fprintf(stderr, "...")` over `printf("..")` and
lose the space before the start parenthesis. Also, line wrap
your commit message.
Side note, use git send-email so that the patch is inline and not a HTML
email for easy review and application of the patch.
Kind Regards,
Edward.
On 01/12/2017 08:49 AM, Xie, AlexBin wrote:
> Hi,
>
>
> v2: Use strerror instead of %m. %m is a GNU C Library extension.
>
> Thanks,
>
> Alex Bin Xie
>
>
> ------------------------------------------------------------------------
> *From:* Xie, AlexBin
> *Sent:* Wednesday, January 11, 2017 4:14 PM
> *To:* amd-gfx at lists.freedesktop.org
> *Subject:* More specific libdrm error message
>
> Hi,
>
> Provide more specific error message if non-privileged user runs amdgpu_test
>
> Before this change, the error message is:" WARNING - Suite
> initialization failed..." People might think this is a driver problem.
>
>
> Tested with non-privileged user. Now the error message is like.
>
> ...
> Error:Permission denied. Hint: Try to run this test program as root.
> WARNING - Suite initialization failed for 'Basic Tests'.
>
> ...
>
>
>
> Tested as root with no regression.
>
>
>
> Please review.
>
>
> Thanks,
>
> Alex Bin Xie
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170112/e6fc249c/attachment.sig>
