Yeah, make sense thanks BR Monk ________________________________ å??件人: Nils Wallménius <nils.wallmenius at gmail.com> å??é??æ?¶é?´: 2017å¹´1æ??10æ?¥ 15:56:36 æ?¶ä»¶äºº: Liu, Monk æ??é??: amd-gfx at lists.freedesktop.org 主é¢?: Re: [PATCH 6/7] drm/amdgpu:alloc/dealloc csa accordingly Hi Monk, a comment below. Den 9 jan. 2017 9:07 fm skrev "Monk Liu" <Monk.Liu at amd.com<mailto:Monk.Liu at amd.com>>: Change-Id: I110af93c4f17ab18d1be199c6ebe9ee965483a66 Signed-off-by: Monk Liu <Monk.Liu at amd.com<mailto:Monk.Liu at amd.com>> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index f82919d..5253aa2 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -1384,6 +1384,10 @@ static int amdgpu_init(struct amdgpu_device *adev) return r; } adev->ip_blocks[i].status.hw = true; + + /* right after GMC hw init, we create CSA */ + if (amdgpu_sriov_vf(adev)) + adev->virt.allocate_csa(adev); The amdgpu_allocate_static_csa function returns a value, presumably an error on failure. Shouldn't the return value be checked here and errors handled? Best regards, Nils } } @@ -1517,6 +1521,9 @@ static int amdgpu_fini(struct amdgpu_device *adev) adev->ip_blocks[i].status.late_initialized = false; } + if (amdgpu_sriov_vf(adev)) + adev->virt.deallocate_csa(adev); + return 0; } -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170110/54b0fee8/attachment-0001.html>
