On 2017-01-09 01:00 PM, Deucher, Alexander wrote: >> -----Original Message----- >> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf >> Of Andres Rodriguez >> Sent: Monday, January 09, 2017 12:01 PM >> To: Emil Velikov >> Cc: amd-gfx mailing list >> Subject: Re: [PATCH 1/3] headers: Sync {amdgpu,radeon}_drm.h with the >> kernel >> >> >> >> On 2017-01-09 11:23 AM, Emil Velikov wrote: >>> Thank you Andres. There's a small nit below. >>> >>> On 5 January 2017 at 00:29, Andres Rodriguez <andresx7 at gmail.com> >> wrote: >>>> Generated using make headers_install from: >>>> airlied/drm-next 2cf026a Merge branch 'linux-4.10' ... >>>> >>>> Manually re-added missing RADEON_TILING_R600_NO_SCANOUT as >> documented on >>>> README >>>> >>> "Thou Shalt Not make any manual changes to include/drm/*h" >>> >>> Please check if there's released open-source userspace which depends >>> on this. If there's none just drop it all together, alternatively >>> please update the kernel header(s). >> Gallium in mesa depends on this, so I'll update the kernel headers >> accordingly. > IIRC, these are not required for the ioctls, they were just put in here since the header is shared between multiple userspace components. > > Alex Would it still be okay to add it to the kernel side then? Having multiple userspace components depend on it would make it complicated to get a patch merged into each of them. Andres >> Thanks again for pointing me to the README, it was pretty useful. >> >> Regards, >> Andres >> >>> Thanks >>> Emil >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx at lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
