On Fri, Dec 23, 2016 at 04:45:52PM +0800, Rex Zhu wrote: You need add signed-by-off and descriptions here. > Change-Id: I4a46440882cd94fe5e77e3f351aaccc218a2ece5 > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 17 +++++++++++++++++ > drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 4 ++-- > drivers/gpu/drm/amd/include/amd_shared.h | 1 + > drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 3 ++- > drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 3 ++- > 5 files changed, 24 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > index 2bfede8..8438642 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > @@ -124,6 +124,7 @@ static ssize_t amdgpu_get_dpm_forced_performance_level(struct device *dev, > (level & AMD_DPM_FORCED_LEVEL_LOW) ? "low" : > (level & AMD_DPM_FORCED_LEVEL_HIGH) ? "high" : > (level & AMD_DPM_FORCED_LEVEL_MANUAL) ? "manual" : > + (level & AMD_DPM_FORCED_LEVEL_PROFILING) ? "profiling" : > "unknown")); > @@ -150,11 +154,24 @@ static ssize_t amdgpu_set_dpm_forced_performance_level(struct device *dev, > level = AMD_DPM_FORCED_LEVEL_AUTO; > } else if (strncmp("manual", buf, strlen("manual")) == 0) { > level = AMD_DPM_FORCED_LEVEL_MANUAL; > + } else if (strncmp("profile", buf, strlen("profile")) == 0) { > + level = AMD_DPM_FORCED_LEVEL_PROFILING; We would better algin get/set (input/output) word with profiling or profile. With that fixed, patch is Reviewed-by: Huang Rui <ray.huang at amd.com>