On 15.02.2017 14:35, Nicolai Hähnle wrote: > On 14.02.2017 13:51, Christian König wrote: >> Am 14.02.2017 um 13:00 schrieb Nicolai Hähnle: >>> On 14.02.2017 11:49, Christian König wrote: >>>> Am 14.02.2017 um 11:37 schrieb Nicolai Hähnle: >>>>> From: Nicolai Hähnle <nicolai.haehnle at amd.com> >>>>> >>>>> Allow callers to opt out of calling ttm_bo_validate immediately. This >>>>> allows more flexibility in how locking of the reservation object is >>>>> done, which is needed to fix a locking bug (destroy locked mutex) >>>>> in amdgpu. >>>>> >>>>> Signed-off-by: Nicolai Hähnle <nicolai.haehnle at amd.com> >>>> >>>> Please squash that into your other patch. It fixes another bug, but I >>>> don't think fixing one bug just to run into another is really a good >>>> idea. >>> >>> I don't understand. I'm not aware that this patch fixes anything, it >>> just enables the subsequent fix in amdgpu in patch #2. I don't think >>> squashing those together is a good idea (one is in ttm, the other in >>> amdgpu). >> >> Ok, forget it I've messed up the different reference count. >> >> With at least initializing bo->kref and bo->destroy before returning the >> first error the patch is Reviewed-by: Christian König >> <christian.koenig at amd.com>. > > Thanks. Does this apply to patches #2 and #3 as well? Well, there's some minor necessary rebase fixes, so I'll probably just send out a new version once I got to test it. Nicolai
