Am 08.02.2017 um 10:41 schrieb Monk Liu:
> ib_pool init should prior to fbdev_init, otherwise
> there will be error from amdgpu_sa_bo_new
> (amdgpu_sa.c:323)
>
> fbdev_init will call ttm_validate which further call
> amdgpu_sa_bo_new.
>
> Change-Id: I3a969570d443f61a44f67b0d76b3871ca5c3ea81
> Signed-off-by: Monk Liu <Monk.Liu at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index afcae15..4169bb1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1918,14 +1918,14 @@ int amdgpu_device_init(struct amdgpu_device *adev,
> /* Get a log2 for easy divisions. */
> adev->mm_stats.log2_max_MBps = ilog2(max(1u, max_MBps));
>
> - amdgpu_fbdev_init(adev);
> -
> r = amdgpu_ib_pool_init(adev);
> if (r) {
> dev_err(adev->dev, "IB initialization failed (%d).\n", r);
> goto failed;
> }
>
> + amdgpu_fbdev_init(adev);
> +
As noted internally as well, please more that one more further down
behind the call to amdgpu_ib_ring_tests().
With that changed the patch is Reviewed-by: Christian König
<christian.koenig at amd.com>.
Regards,
Christian.
> r = amdgpu_ib_ring_tests(adev);
> if (r)
> DRM_ERROR("ib ring test failed (%d).\n", r);
