Indeed a very nice set, only briefly looked over it and only found a small issue on patch #2. Apart from that the set is Acked-by: Christian König <christian.koenig at amd.com>. Regards, Christian. Am 04.02.2017 um 13:08 schrieb Edward O'Callaghan: > This series is, > Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net> > > On 02/04/2017 03:51 PM, Andres Rodriguez wrote: >> Instead of taking the first pipe and givint the rest to kfd, take the > s/givint/giving/ > >> first 2 queues of each pipe. >> >> Effectively, amdgpu and amdkfd own the same number of queues. But >> because the queues are spread over multiple pipes the hardware will be >> able to better handle concurrent compute workloads. >> >> amdgpu goes from 1 pipe to 4 pipes, i.e. from 1 compute threads to 4 >> amdkfd goes from 3 pipe to 4 pipes, i.e. from 3 compute threads to 4 >> >> Signed-off-by: Andres Rodriguez <andresx7 at gmail.com> >> --- >> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 2 +- >> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c >> index 2218b65..da28174 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c >> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c >> @@ -2810,7 +2810,7 @@ static void gfx_v7_0_compute_queue_acquire(struct amdgpu_device *adev) >> break; >> >> /* policy: amdgpu owns all queues in the first pipe */ >> - if (mec == 0 && pipe == 0) >> + if (mec == 0 && queue < 2) >> set_bit(i, adev->gfx.mec.queue_bitmap); >> } >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> index 04b4448..0a16cab 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c >> @@ -1436,7 +1436,7 @@ static void gfx_v8_0_compute_queue_acquire(struct amdgpu_device *adev) >> break; >> >> /* policy: amdgpu owns all queues in the first pipe */ >> - if (mec == 0 && pipe == 0) >> + if (mec == 0 && queue < 2) >> set_bit(i, adev->gfx.mec.queue_bitmap); >> } >> >> > > > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170206/d2d21575/attachment-0001.html>
