Thanks Alex and Christian. Patch7 is just a workaround for issue: when dpm disabled, can't initialize uvd on Ci. Now I have found the root cause. so no need to add timeout time. Please review the attached patch. Best Regards Rex ________________________________ From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Christian König <deathsimple at vodafone.de> Sent: Friday, January 27, 2017 4:34 PM To: Zhu, Rex; amd-gfx at lists.freedesktop.org Subject: Re: [PATCH 00/12] mise patch related uvd/vce cg and pg. I only skimmed over it, but what I saw looked mostly good to me. Patch #7: Please add a code comment explaining why we do this. Apart from that the rest is Acked-by: Christian König <christian.koenig at amd.com>. Regards, Christian. Am 26.01.2017 um 12:00 schrieb Rex Zhu: > Rex Zhu (12): > drm/amdgpu: when dpm disabled, also can enable uvd cg/pg. > drm/amdgpu: add current_pg_status register define for smu7.1 > drm/amdgpu: power down/up uvd4 when smu disabled. > drm/amdgpu: refine uvd pg code in kv_dpm.c > drm/amdgpu: refine uvd4.2 init/stop code. > drm/amdgpu: refine uvd5.0/6.0 code. > drm/amdgpu: add uvd timeout time. > drm/amdgpu: when dpm disabled, also need to stop/start vce. > drm/amdgpu: refine code for VCE2.0 and related dpm code. > drm/amdgpu: enable vce pg feature on Kv. > drm/amdgpu: move subfunctions to the front of vce_v2_0.c. > drm/amdgpu: refine vce3.0 code and related powerplay pg code. > > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 12 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 12 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 9 + > drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 9 - > drivers/gpu/drm/amd/amdgpu/cik.c | 4 +- > drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 68 +--- > drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 130 ++++-- > drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 24 +- > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 21 +- > drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 451 +++++++++++---------- > drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 17 +- > .../gpu/drm/amd/include/asic_reg/smu/smu_7_0_1_d.h | 1 + > .../drm/amd/powerplay/hwmgr/cz_clockpowergating.c | 71 ++-- > .../amd/powerplay/hwmgr/smu7_clockpowergating.c | 23 +- > 14 files changed, 438 insertions(+), 414 deletions(-) > _______________________________________________ amd-gfx mailing list amd-gfx at lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx amd-gfx Info Page - lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx> lists.freedesktop.org To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ... -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170203/91c1014a/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-drm-amdgpu-fix-uvd-can-t-initialized-when-dpm-disabl.patch Type: application/octet-stream Size: 2228 bytes Desc: 0001-drm-amdgpu-fix-uvd-can-t-initialized-when-dpm-disabl.patch URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170203/91c1014a/attachment.obj>
