[PATCH 4/6] drm/ttm: init locked again to prevent incorrect unlock

christian.koenig@xxxxxxx (Christian König) · Wed, 13 Dec 2017 10:48:52 +0100

Am 13.12.2017 um 03:06 schrieb He, Roger:
> 	That is a bug fix, isn't it? If yes maybe add CC:stable and commit it first before all other patches.
>
> Fortunately so far there is no issue directly resulted from that.

Yeah, but that is irrelevant. Patches are classified as fix if they fix 
something, not if the bug was ever hit.

Not sure if the code is already upstream, but we should still make sure 
that we send this patch to the appropriate places.

Christian.

>
> Thanks
> Roger(Hongbo.He)
>
> -----Original Message-----
> From: Christian KÃ¶nig [mailto:ckoenig.leichtzumerken at gmail.com]
> Sent: Tuesday, December 12, 2017 6:37 PM
> To: He, Roger <Hongbo.He at amd.com>; amd-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
> Subject: Re: [PATCH 4/6] drm/ttm: init locked again to prevent incorrect unlock
>
> Am 12.12.2017 um 10:33 schrieb Roger He:
>> Change-Id: I8db51d843955f5db14bb4bbff892eaedbd9f0abe
>> Signed-off-by: Roger He <Hongbo.He at amd.com>
> Reviewed-by: Christian KÃ¶nig <christian.koenig at amd.com>
>
> That is a bug fix, isn't it? If yes maybe add CC:stable and commit it first before all other patches.
>
> Christian.
>
>> ---
>>    drivers/gpu/drm/ttm/ttm_bo.c | 1 +
>>    1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c
>> b/drivers/gpu/drm/ttm/ttm_bo.c index 17fe8be..eb8c568 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>> @@ -735,6 +735,7 @@ static int ttm_mem_evict_first(struct ttm_bo_device *bdev,
>>    								      place)) {
>>    				if (locked)
>>    					reservation_object_unlock(bo->resv);
>> +				locked = false;
>>    				continue;
>>    			}
>>    			break;