On Tue, Dec 12, 2017 at 10:01 AM, Christian König <ckoenig.leichtzumerken at gmail.com> wrote: > Am 11.12.2017 um 22:29 schrieb Marek Olšák: >> >> From: Marek Olšák <marek.olsak at amd.com> >> >> Signed-off-by: Marek Olšák <marek.olsak at amd.com> >> --- >> >> Is this really correct? I have no easy way to test it. > > > It's a step in the right direction, but I would rather vote for something > else: > > Instead of disabling the timeout by default we only disable the GPU > reset/recovery. > > The idea is to add a new parameter amdgpu_gpu_recovery which makes > amdgpu_gpu_recover only prints out an error and doesn't touch the GPU at all > (on bare metal systems). > > Then we finally set the amdgpu_lockup_timeout to a non zero value by > default. > > Andrey could you take care of this when you have time? I don't understand this. Why can't we keep the previous behavior where amdgpu.lockup_timeout=0 disabled GPU reset? Why do we have to add another option for the same thing? Marek
