Hi Emil, On Fri, Dec 01, 2017 at 02:40:11PM +0000, Emil Velikov wrote: > On 30 November 2017 at 23:49, Sudip Mukherjee > <sudipm.mukherjee at gmail.com> wrote: > > Hi Daniel, > > > > On Wed, Nov 29, 2017 at 10:56:34AM +0100, Daniel Vetter wrote: <snip> > > submit it to dri-devel. > > > A crazy idea, mostly towards Tedd and Sudip: > > Start small and build gradually. An example split for separate patch series: > > - one HW, basic setup + atomic KMS > - add second HW > - more KMS features > - fancy memory management > - 2D/3D/other acceleration > > The driver as seen above tries to do all of the above (almost, it's not atomic) > at once - 40k loc. > > Someone familiar with the code can quickly split it up and while doing > so, feed it through checkpatch. I can try but will be very tough since I have to go through the code to get familiar with it and, as mentioned before, its not part of my dayjob, so time will be a problem. Developing from scratch takes much more time than fixing something. > Current code is _very_ far from kernel coding style, plus the > copyright blurp is very disturbing: I will fix the coding style before my first submission to dri-devel, which should be in January after I have setup my desktop with the hardware for testing. The copyright thing - I am sure Teddy can talk to his company and will confirm that we can change it to the way kernel code is done. -- Regards Sudip
