On Fri, Aug 18, 2017 at 02:10:30PM -0400, Alex Deucher wrote:
> +++ b/sound/soc/amd/Kconfig
> @@ -2,3 +2,10 @@ config SND_SOC_AMD_ACP
> tristate "AMD Audio Coprocessor support"
> help
> This option enables ACP DMA support on AMD platform.
> +config SND_SOC_AMD_CZ_RT5645_MACH
> + tristate "AMD CZ support for RT5645"
Missing blank line between the stanzas.
> + select SND_SOC_RT5645
> + select SND_SOC_AMD_ACP
> + depends on I2C_DESIGNWARE_PLATFORM
No system dependencies of any kind? Looking at this I'd expect at least
CONFIG_ACPI || COMPILE_TEST. It's also unclear to me how the DesignWare
device is going to be instantiated here or if that should be a direct
depenency at all here.
> + ret = snd_soc_register_card(card);
devm_snd_soc_register_card() and then you don't need the remove
function.
> +static const struct acpi_device_id cz_audio_acpi_match[] = {
> + { "AMDI1002", 0 },
> + {},
> +};
> +
Missing MODULE_DEVICE_TABLE().
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170831/d085e45c/attachment.sig>
