On 30/08/17 03:09 PM, Christian König wrote: > Am 29.08.2017 um 19:20 schrieb Deucher, Alexander: >>> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf >>> Of Christian König >>> >>> @@ -89,6 +89,8 @@ extern "C" { >>> #define AMDGPU_GEM_CREATE_SHADOW (1 << 4) >>> /* Flag that allocating the BO should use linear VRAM */ >>> #define AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS (1 << 5) >>> +/* Flag that BO is local in the VM */ >>> +#define AMDGPU_GEM_CREATE_LOCAL (1 << 6) >> I'm not crazy about the name LOCAL. Maybe something like ALWAYS_VALID? > > Works for me as well. Dave any other opinion? > > If everybody is ok with ALWAYS_VALID I'm going to use that one. FWIW, I like LOCAL better than ALWAYS_VALID. The latter suggests that the BO is valid under any circumstances, whereas LOCAL indicates that it cannot be used outside of the GPUVM it was created in. I don't feel strongly about it though, feel free to go with either. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
