On 25/08/17 08:59 AM, Russell, Kent wrote: > There is GPU Power usage reported through amdgpu_pm_info, which also has some other information as well. I'd like that in sysfs, but I am unsure if we are allowed to due to the other information reported there. I thought the sensors were added to the DRM ioctl but apparently not. Seems like that might be a bit easier place to put them than creating sysfs entries for every single sensor (it also means as new sensors are added you have to circle around back to add yet more sysfs entries). Tom > > Kent > > -----Original Message----- > From: StDenis, Tom > Sent: Friday, August 25, 2017 8:58 AM > To: Christian König; Russell, Kent; amd-gfx at lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: Add sysfs file for VBIOS > > On 25/08/17 08:56 AM, Christian König wrote: >> Hi Kent, >> >> agree on the VBIOS dump file, that clearly belongs to debugsf. >> >> The power usage stuff I can't say much about cause I'm not deeply into >> this, but keep in mind the restriction for sysfs: >> 1. It's a stable interface. So it must be very well designed. >> 2. Only one value per file. I think the power stuff doesn't fulfill >> that requirement at the moment. > > What "power" stuff are we talking about? The sensors interface or the pm_info or something else? > > Keep in mind umr uses the sensors debugfs file in --top mode. > > Tom >
