On 2017-08-13 04:29 AM, Oded Gabbay wrote: > On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling <Felix.Kuehling at amd.com> wrote: >> Remove hard-coded assumption that the first compute pipe is >> reserved for amdgpu. Pipe 0 actually means pipe 0 now. >> > If I'm looking at amdgpu_gfx_compute_queue_acquire(), amdgpu takes the > first pipe, so won't this change collide with that code ? amdgpu_gfx_compute_queue_acquire marks the queues it's using in adev->gfx.mec.queue_bitmap. amdgpu_amdkfd_device_init uses that to initialize the queue_bitmap in kgd2kfd_shared_resources. So KFD is not going to use the compute queues reserved by amdgpu. Andres Rodriguez had a series of commits a few months ago to generalize the compute queue assignment between amdgpu and amdkfd. The hard coded assumption that pipe0 is used by amdgpu goes back to before Andres' patch series. I think it was overlooked when Andres made his changes. Regards, Felix
