On 27/04/17 06:05 PM, Christian König wrote: > >> 2. In this function and caller functions, the error handling for such >> interrupt is complicated and risky. When the waiting is interrupted by >> a signal, the callers of this function need to handle this interrupt >> error. I traced the calling stack all the way back to function >> drm_mode_page_flip_ioctl. I could not find an issue. But I am not sure >> about even upper layer. Is this IOCTL restartable? How about further >> higher layer? Since I didn't see benefit in point 1. So I thought it >> was a good idea to change. > > The page flip IOCTL should be restartable. I think all drm IOCTLs with > driver callbacks are restartable, but I'm not 100% sure, Michel probably > knows that better. Yes, I'm pretty sure it is. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer