On 19/04/17 11:07 AM, Christian König wrote: > Am 19.04.2017 um 17:03 schrieb Tom St Denis: >> So it's more obvious which rings are using which INV engines. >> >> Signed-off-by: Tom St Denis <tom.stdenis at amd.com> > > I wonder if we shouldn't stop printing the ring numbers completely in > the ring and IB tests as well and always use the ring name. > > But anyway for now the patch is Reviewed-by: Christian König > <christian.koenig at amd.com>. Thanks. I'm not sure if others have built scripts/etc on the ring numbers so for now I was trying not to deviate too far. umr always refers to rings by their name (e.g. in debugfs) but like having the name in the ip_funcs tables it's just easier to debug if the info has human readable names. Cheers, Tom > > Regards, > Christian. > >> --- >> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c >> b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c >> index a71521e10763..edf43769ae70 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c >> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c >> @@ -394,8 +394,9 @@ static int gmc_v9_0_late_init(void *handle) >> unsigned vmhub = ring->funcs->vmhub; >> ring->vm_inv_eng = vm_inv_eng[vmhub]++; >> - dev_info(adev->dev, "ring %u uses VM inv eng %u on hub %u\n", >> - ring->idx, ring->vm_inv_eng, ring->funcs->vmhub); >> + dev_info(adev->dev, "ring %u(%s) uses VM inv eng %u on hub >> %u\n", >> + ring->idx, ring->name, ring->vm_inv_eng, >> + ring->funcs->vmhub); >> } >> /* Engine 17 is used for GART flushes */ > >
