On 2017å¹´04æ??18æ?¥ 09:51, Zhang, Jerry (Junwei) wrote:
>
> Anyone could help to review it?
>
> On 04/17/2017 05:04 PM, Junwei Zhang wrote:
>> Signed-off-by: Junwei Zhang <Jerry.Zhang at amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 +++++
>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 1 +
>> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
>> 3 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> index 9ff445c..51aedf9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -1269,6 +1269,11 @@ int amdgpu_vm_bo_update(struct amdgpu_device
>> *adev,
>> spin_unlock(&vm->status_lock);
>>
>> list_for_each_entry(mapping, &bo_va->invalids, list) {
>> + if (mapping->flags & AMDGPU_PTE_TILED) {
>> + flags |= AMDGPU_PTE_TILED;
>> + flags &= ~AMDGPU_PTE_VALID;
>> + }
>> +
How about clear operation?
>> r = amdgpu_vm_bo_split_mapping(adev, exclusive,
>> gtt_flags, pages_addr, vm,
>> mapping, flags, mem,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>> index 4904740..8d25914 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>> @@ -70,6 +70,7 @@
>> /* VEGA10 only */
>> #define AMDGPU_PTE_MTYPE(a) ((uint64_t)a << 57)
>> #define AMDGPU_PTE_MTYPE_MASK AMDGPU_PTE_MTYPE(3ULL)
>> +#define AMDGPU_PTE_TILED (1ULL << 51)
>>
>> /* How to programm VM fault handling */
>> #define AMDGPU_VM_FAULT_STOP_NEVER 0
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> index 51a1919..6d033ae 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> @@ -324,7 +324,7 @@ static uint64_t gmc_v9_0_get_vm_pte_flags(struct
>> amdgpu_device *adev,
>> }
>>
>> if (flags & AMDGPU_VM_PAGE_PRT)
>> - pte_flag |= AMDGPU_PTE_PRT;
>> + pte_flag |= AMDGPU_PTE_TILED;
PTE_PRT name doesn't make sense?
Regards,
David Zhou
>>
>> return pte_flag;
>> }
>>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
