> -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Monday, April 17, 2017 9:23 AM > To: amd-gfx at lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH] drm/amd/powerplay: delete dead functions in vega10. > > Vega10 does not support AVFS BTC, remove function. > > Change-Id: If9e7845e581e0e3062febca2c81620ca6ba26016 Missing your signed-off-by. With that fixed: Reviewed-by: Alex Deucher <alexander.deucher at amd.com > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 30 ++----------- > --------- > .../gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 9 ------- > .../gpu/drm/amd/powerplay/smumgr/vega10_smumgr.h | 1 - > 3 files changed, 2 insertions(+), 38 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c > b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c > index 561b837..3e11abe 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c > @@ -2411,35 +2411,9 @@ static int vega10_init_smc_table(struct pp_hwmgr > *hwmgr) > PP_ASSERT_WITH_CODE(!result, > "Failed to upload PPtable!", return result); > > - if (data->smu_features[GNLD_AVFS].supported) { > - uint32_t features_enabled; > - result = vega10_get_smc_features(hwmgr->smumgr, > &features_enabled); > - PP_ASSERT_WITH_CODE(!result, > - "Failed to Retrieve Enabled Features!", > - return result); > - if (!(features_enabled & (1 << FEATURE_AVFS_BIT))) { > - result = vega10_perform_btc(hwmgr->smumgr); > - PP_ASSERT_WITH_CODE(!result, > - "Failed to Perform BTC!", > + result = vega10_avfs_enable(hwmgr, true); > + PP_ASSERT_WITH_CODE(!result, "Attempt to enable AVFS feature > Failed!", > return result); > - result = vega10_avfs_enable(hwmgr, true); > - PP_ASSERT_WITH_CODE(!result, > - "Attempt to enable AVFS feature > Failed!", > - return result); > - result = vega10_save_vft_table(hwmgr->smumgr, > - (uint8_t *)&(data- > >smc_state_table.avfs_table)); > - PP_ASSERT_WITH_CODE(!result, > - "Attempt to save VFT table Failed!", > - return result); > - } else { > - data->smu_features[GNLD_AVFS].enabled = true; > - result = vega10_restore_vft_table(hwmgr->smumgr, > - (uint8_t *)&(data- > >smc_state_table.avfs_table)); > - PP_ASSERT_WITH_CODE(!result, > - "Attempt to restore VFT table > Failed!", > - return result;); > - } > - } > > return 0; > } > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c > b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c > index 2685f02..7a36a74 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c > @@ -299,15 +299,6 @@ int vega10_copy_table_to_smc(struct pp_smumgr > *smumgr, > return 0; > } > > -int vega10_perform_btc(struct pp_smumgr *smumgr) > -{ > - > PP_ASSERT_WITH_CODE(!vega10_send_msg_to_smc_with_parame > ter( > - smumgr, PPSMC_MSG_RunBtc, 0), > - "Attempt to run DC BTC Failed!", > - return -1); > - return 0; > -} > - > int vega10_save_vft_table(struct pp_smumgr *smumgr, uint8_t > *avfs_table) > { > PP_ASSERT_WITH_CODE(avfs_table, > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.h > b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.h > index ad05021..71e9b64 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.h > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.h > @@ -62,7 +62,6 @@ int vega10_get_smc_features(struct pp_smumgr > *smumgr, > uint32_t *features_enabled); > int vega10_save_vft_table(struct pp_smumgr *smumgr, uint8_t > *avfs_table); > int vega10_restore_vft_table(struct pp_smumgr *smumgr, uint8_t > *avfs_table); > -int vega10_perform_btc(struct pp_smumgr *smumgr); > > int vega10_set_tools_address(struct pp_smumgr *smumgr); > > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
