On 10/04/17 06:42 PM, Emil Velikov wrote: > On 10 April 2017 at 09:37, Michel Dänzer <michel at daenzer.net> wrote: >> From: Daniel Stone <daniels at collabora.com> >> >> DRM_EVENT_CONTEXT_VERSION is the latest context version supported by >> whatever version of libdrm is present. We were blindly asserting we >> supported whatever version that may be, even if we actually didn't. >> >> With libdrm 2.4.78, setting a higher context version than 2 will attempt >> to call the page_flip_handler2 vfunc if it was non-NULL, which being a >> random chunk of stack memory, it might well have been. >> > Should be safe since we use xnfcalloc [in RADEONGetRec]. That's a good point, thanks (applies equally to the modesetting driver AFAICT); I'll drop the second paragraph from the commit log. > Regardless, the amdgpu and ati patches are > Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com> Thanks! -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
