On Mon, Apr 03, 2017 at 03:12:31PM -0400, Alex Deucher wrote:
> On Mon, Apr 3, 2017 at 2:53 PM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> > Hello Ken Wang,
> >
> > The patch 220ab9bd1ccf: "drm/amdgpu: soc15 enable (v3)" from Mar 6,
> > 2017, leads to the following static checker warning:
> >
> > drivers/gpu/drm/amd/amdgpu/soc15.c:110 soc15_pcie_rreg()
> > error: potentially dereferencing uninitialized 'nbio_pcie_id'.
> >
> > drivers/gpu/drm/amd/amdgpu/soc15.c
> > 101 static u32 soc15_pcie_rreg(struct amdgpu_device *adev, u32 reg)
> > 102 {
> > 103 unsigned long flags, address, data;
> > 104 u32 r;
> > 105 struct nbio_pcie_index_data *nbio_pcie_id;
> > 106
> > 107 if (adev->asic_type == CHIP_VEGA10)
> > 108 nbio_pcie_id = &nbio_v6_1_pcie_index_data;
> >
> > There should be an else statement to this probably?
>
> Currently vega10 is the only soc15 gpu so there is else case yet.
>
Yeah. I figured. But it's annoying to have half implemented code and
static checker warnings.
regards,
dan carpenter
