An upcoming GPU generation (Vega). From: amd-gfx [mailto:amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of Mike Lothian Sent: Monday, December 19, 2016 10:49 PM To: Liu, Monk; amd-gfx at lists.freedesktop.org Subject: Re: [PATCH 02/23] drm/amdgpu: add kiq into compiling I'd be curious to know what AI stands for in this context On Mon, 19 Dec 2016 at 07:28 Liu, Monk <Monk.Liu at amd.com<mailto:Monk.Liu at amd.com>> wrote: Sorry, NAK for the KIQ implement patches. KIQ is just another compute queue, and each generation of compute queue initialization is different, so there is no need of a amdgpu_kiq.c file to cover the function of kiq, Kiq is good enough to be in each gfx_x_x.c file .e.g : KIQ for VI is in gfx_v8_0.c And KIQ for AI is in gfx_v9_0.c Most important is that the "queue_init" routine of above two chips on KIQ is different (MQD descriptor as well as registers need programing ... ), please just align with the previous patch style in amd-sriov-4.6 for KIQ part BR Monk -----é?®ä»¶å??件----- å??件人: Yu, Xiangliang å??é??æ?¶é?´: Sunday, December 18, 2016 9:47 AM æ?¶ä»¶äºº: dl.SRDC_SW_GPUVirtualization 主é¢?: FW: [PATCH 02/23] drm/amdgpu: add kiq into compiling -----Original Message----- From: Xiangliang Yu [mailto:Xiangliang.Yu@xxxxxxx<mailto:Xiangliang.Yu at amd.com>] Sent: Sunday, December 18, 2016 12:16 AM To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>; dl.SRDC_SW_GPUVirtualization <dl.SRDC_SW_GPUVirtualization at amd.com<mailto:dl.SRDC_SW_GPUVirtualization at amd.com>> Cc: Yu, Xiangliang <Xiangliang.Yu at amd.com<mailto:Xiangliang.Yu at amd.com>> Subject: [PATCH 02/23] drm/amdgpu: add kiq into compiling Add support KIQ in Makefile to make it into module. Signed-off-by: Xiangliang Yu <Xiangliang.Yu at amd.com<mailto:Xiangliang.Yu at amd.com>> --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile b/drivers/gpu/drm/amd/amdgpu/Makefile index dd0b6db..635ff94 100644 --- a/drivers/gpu/drm/amd/amdgpu/Makefile +++ b/drivers/gpu/drm/amd/amdgpu/Makefile @@ -30,7 +30,7 @@ amdgpu-y += amdgpu_device.o amdgpu_kms.o \ atombios_encoders.o amdgpu_sa.o atombios_i2c.o \ amdgpu_prime.o amdgpu_vm.o amdgpu_ib.o amdgpu_pll.o \ amdgpu_ucode.o amdgpu_bo_list.o amdgpu_ctx.o amdgpu_sync.o \ - amdgpu_gtt_mgr.o amdgpu_vram_mgr.o + amdgpu_gtt_mgr.o amdgpu_vram_mgr.o amdgpu_kiq.o # add asic specific block amdgpu-$(CONFIG_DRM_AMDGPU_CIK)+= cik.o cik_ih.o kv_smc.o kv_dpm.o \ -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20161220/f67038e6/attachment.html>
