Hi Emil, On 2016-12-19 07:46 AM, Emil Velikov wrote: > Hi Harry, > > On 14 December 2016 at 16:26, Harry Wentland <harry.wentland at amd.com> wrote: >> They are still used all over the place (e.g. >> dc/dce110/dce110_resource.c:413). >> >> We should at least do an spatch to use kzalloc/krealloc/kfree across the >> board if the wrappers are an issue. >> >> NAKed >> > [Ignoring all the heat around the DC/DAL topic for a moment] > > Pardon for reviving this old thread, yet I believe it's beneficial, > esp. for the less experienced open-source/kernel devs. > > There is little-to-no merit of keeping dead code in upstream kernels. > That is, unless there's a series in discussion which uses the code ;-) > > NACKs like this one are not cool, furthermore the tend to > alienate/push away people trying to help. With DC/DAL in mind, I think > you/others want all the help people can offer ;-) > Very good point. I think Dave set me straight pretty quickly there. :) I'll make sure I'll take a much closer look at patches in the future before considering NAKs. My impression here was that this code was not dead, which was obviously a wrong one and a good indication that a lot of the DC codebase is still quite messy. Thanks, Harry > Regards, > Emil >
