Hi Emil, Thing is, with all due respect, the vast majority of DC contributions are likely to come from AMD at the moment. The code is in high flux and requires knowledge about the hardware that the public does not possess. That's not to say that submissions aren't welcomed. But on code that is in flux don't be shocked if you get a higher percentage of NAKs than in other parts of the driver which are relatively static. It's a bit of a catch. The public (re: Linux) wants open, stable, efficient, and featureful drivers but then they want to dictate to the vendor exactly how that's going to be executed. That doesn't really work in practice or theory. The kernel team has standards that AMD has to meet but the process to get there won't always make everyone happy. Once DC is actually cleaned up, validated, and merged into the kernel I suspect the RB/NAK ratio will clean up. Cheers, Tom ________________________________ From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Emil Velikov <emil.l.velikov at gmail.com> Sent: Monday, December 19, 2016 07:46 To: Wentland, Harry Cc: amd-gfx mailing list Subject: Re: [PATCH 2/8] dal: remove some unused wrappers Hi Harry, On 14 December 2016 at 16:26, Harry Wentland <harry.wentland at amd.com> wrote: > They are still used all over the place (e.g. > dc/dce110/dce110_resource.c:413). > > We should at least do an spatch to use kzalloc/krealloc/kfree across the > board if the wrappers are an issue. > > NAKed > [Ignoring all the heat around the DC/DAL topic for a moment] Pardon for reviving this old thread, yet I believe it's beneficial, esp. for the less experienced open-source/kernel devs. There is little-to-no merit of keeping dead code in upstream kernels. That is, unless there's a series in discussion which uses the code ;-) NACKs like this one are not cool, furthermore the tend to alienate/push away people trying to help. With DC/DAL in mind, I think you/others want all the help people can offer ;-) Regards, Emil _______________________________________________ amd-gfx mailing list amd-gfx at lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx amd-gfx Info Page - lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx> lists.freedesktop.org To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ... -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20161219/5496a7e6/attachment.html>
