Hi Flora, Just confirm that it's decimal rather than HEX. + adev->external_rev_id = adev->rev_id + 40; Apart from that, the series of patches looks good for me. Reviewed-by: Junwei Zhang <Jerry.Zhang at amd.com> Regards, Jerry(Junwei Zhang) ________________________________________ From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Flora Cui <Flora.Cui at amd.com> Sent: Thursday, December 15, 2016 3:32:37 PM To: amd-gfx at lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH 9/9] drm/amdgpu: update rev id for verde Change-Id: I9f2a140d635e9758f21a392ae2e976416de9453b Signed-off-by: Flora Cui <Flora.Cui at amd.com> --- drivers/gpu/drm/amd/amdgpu/si.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index 2a99a41..c46b015 100644 --- a/drivers/gpu/drm/amd/amdgpu/si.c +++ b/drivers/gpu/drm/amd/amdgpu/si.c @@ -1229,7 +1229,7 @@ static int si_common_early_init(void *handle) AMD_CG_SUPPORT_HDP_MGCG; adev->pg_flags = 0; //??? - adev->external_rev_id = adev->rev_id + 0x14; + adev->external_rev_id = adev->rev_id + 40; break; case CHIP_OLAND: adev->cg_flags = -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx at lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx