On Tue, 13 Dec 2016, "Cheng, Tony" <tony.cheng at amd.com> wrote:
> I am struggling with that these comminty contributions to DC would be.
>
> Us AMD developer has access to HW docs and designer and we are still
> spending 50% of our time figuring out why our HW doesn't work right. I
> can't image community doing much of this heavy lifting.
I can sympathize with that view, and certainly most of the heavy lifting
would come from you, same as with us and i915. However, when you put
together your hardware, an open source driver, and smart people, they
*will* scratch their itches, whether they're bugs you're not fixing or
features you're missing. Please don't underestimate and patronize them,
it's going to rub people the wrong way.
> Dave sent us series of patch to show how it would look like if someone
> were to change DC. These changes are more removing code that DRM
> already has and deleting/clean up stuff. I guess we can nak all changes
> and "rewrite" our own version of clean up patch community want to see?
Please have a look at, say,
$ git shortlog -sne --since @{1year} -- drivers/gpu/drm/amd | grep -v amd\.com
Do you really want to actively discourage all of them from contributing?
I think this would be detrimental to not only your driver, but the whole
drm community. It feels like you'd like to have your code upstream, but
still retain ownership as if it was in your internal repo. You can't
have your cake and eat it too.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
