[Please CC me on all replies, I'm not subscribed to the list.] Dear Harry, I've sent a couple of questions/suggestions/notes on patches 2, 5, 10 and 12. Since I'm not familiar with the module these comments are mostly stylistic/understanding. But there's also a null pointer dereference question in there. ;-) Apart from that I was wondering, if there is any recent tree containing all of DAL/Display? The latest version I've seen is <https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-4.7>, but that doesn't seem to be based on a more recent 4.9/4.10? Is there a rebased version available somewhere? Thanks, Kai Harry Wentland wrote on 08.12.2016 02:26: > * bunch of warning fixes > * some bug fixes > * more display_clock cleanup > > Andrey Grodzovsky (1): > drm/amd/display: Fix refcount over dc_sink. > > Arindam Nath (1): > drm/amd/display: remove DM_NOT_IMPL messages > > Ding Wang (1): > drm/amd/display: Temporarily blocking interlacing mode until it's > supported. > > Dmytro Laktyushkin (2): > drm/amd/display: moving remaining functionality from gpu to dce_clocks > drm/amd/display: fix up construction of scratch_val_ctx > > Harry Wentland (3): > drm/amd/display: Fix bunch of warnings in DC > drm/amd/display: Fix warning in freesync module > drm/amd/display: Fix warning. Set MAX_SURFACES to 3 > > Tony Cheng (2): > drm/amd/display: fix indexing bug > drm/amd/display: avoid apply_clk_constraints for address update > > Zeyu Fan (2): > drm/amd/display: Fix bugs causing Hawaii and Bonaire not light up. > drm/amd/display: Fix hdmi not lighting up on Hawaii. > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 20 +- > drivers/gpu/drm/amd/display/dc/Makefile | 7 +- > .../dc/bios/dce110/command_table_helper_dce110.c | 2 +- > .../dc/bios/dce112/command_table_helper_dce112.c | 2 +- > .../gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c | 2 +- > drivers/gpu/drm/amd/display/dc/core/dc.c | 20 +- > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 5 +- > drivers/gpu/drm/amd/display/dc/dc.h | 2 +- > .../gpu/drm/amd/display/dc/dce/dce_clock_source.c | 5 - > drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c | 142 +++++++++-- > drivers/gpu/drm/amd/display/dc/dce/dce_clocks.h | 36 ++- > .../gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 4 +- > drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 2 - > .../display/dc/dce110/dce110_timing_generator.c | 4 + > .../drm/amd/display/dc/dce110/dce110_transform_v.c | 3 +- > drivers/gpu/drm/amd/display/dc/gpu/Makefile | 21 -- > .../display/dc/gpu/dce112/display_clock_dce112.c | 277 --------------------- > .../display/dc/gpu/dce112/display_clock_dce112.h | 79 ------ > drivers/gpu/drm/amd/display/dc/gpu/divider_range.c | 127 ---------- > drivers/gpu/drm/amd/display/dc/gpu/divider_range.h | 62 ----- > drivers/gpu/drm/amd/display/dc/inc/core_types.h | 4 +- > .../inc/hw/display_clock.h} | 27 +- > .../drm/amd/display/modules/freesync/freesync.c | 3 + > 23 files changed, 207 insertions(+), 649 deletions(-) > delete mode 100644 drivers/gpu/drm/amd/display/dc/gpu/Makefile > delete mode 100644 drivers/gpu/drm/amd/display/dc/gpu/dce112/display_clock_dce112.c > delete mode 100644 drivers/gpu/drm/amd/display/dc/gpu/dce112/display_clock_dce112.h > delete mode 100644 drivers/gpu/drm/amd/display/dc/gpu/divider_range.c > delete mode 100644 drivers/gpu/drm/amd/display/dc/gpu/divider_range.h > rename drivers/gpu/drm/amd/display/{include/display_clock_interface.h => dc/inc/hw/display_clock.h} (75%) > -- Kai Wasserbäch (Kai Wasserbaech) E-Mail: kai at dev.carbon-project.org -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: OpenPGP digital signature URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20161208/fa17d7c7/attachment.sig>
