[PATCH] drm/amdgpu: cleanup amdgpu_cs_ioctl to make code logicality clear

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 31, 2016 at 05:14:26PM +0800, Christian K�nig wrote:
> Am 31.10.2016 um 09:58 schrieb Huang Rui:
> > On Mon, Oct 31, 2016 at 03:53:52PM +0800, Christian K?nig wrote:
> >> Am 31.10.2016 um 03:08 schrieb Huang Rui:
> >>> Signed-off-by: Huang Rui <ray.huang at amd.com>
> >> Looks good to me, patch is Reviewed-by: Christian K?nig
> >> <christian.koenig at amd.com>.
> >>
> >> BTW: amdgpu_cs_handle_lockup() is a leftover from radeon and can be
> >> removed. Would be nice if you can take care of this as well.
> >>
> > Sure. amdgpu_cs_handle_lockup actually will trigger a gpu reset when r ==
> > -EDEADLK. I'm not very clear with why we needn't gpu reset on that case
> > yet, could you explain?
> 
> On radeon the fence wait function returned -EDEADLK when it detected 
> that the hardware is locked up.
> 
> In the CS and GEM IOCTLs we then catch this error, reseted the hardware 
> and tried again.
> 
> Since we never return -EDEADLK any more we can just drop the handling 
> for this.
> 

Yep, I see. Thanks to clarify it.

Thanks,
Rui


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux