[PATCH] drm/amdgpu/vce3: only enable 3 rings on new enough firmware

[deathsimple@xxxxxxxxxxx (Christian König)]

Am 25.10.2016 um 15:41 schrieb Alex Deucher:
> Older firmware versions don't support 3 rings.
>
> fixes:
> https://bugs.freedesktop.org/show_bug.cgi?id=98016
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> index 5ed2930..55cfc53 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> @@ -382,6 +382,10 @@ static int vce_v3_0_sw_init(void *handle)
>   	if (r)
>   		return r;
>   
> +	/* 52.8.3 required for 3 ring support */
> +	if (adev->vce.fw_version < 0x34080300)

Could you add a define like we do in amdgpu_uvd.c for the firmware? 
0x34080300 is not so easily readable if you don't know what to look for.

Only nice to have, so either way patch is Reviewed-by: Christian König 
<christian.koenig at amd.com>.

Regards,
Christian.

> +		adev->vce.num_rings = 2;
> +
>   	r = amdgpu_vce_resume(adev);
>   	if (r)
>   		return r;