Hi Alex: Yes, feel free to add my RB, Reviewed-by: JimQu <Jim.Qu at amd.com> Thanks JimQu ________________________________________ å??件人: Alex Deucher <alexdeucher at gmail.com> å??é??æ?¶é?´: 2016å¹´10æ??20æ?¥ 2:46 æ?¶ä»¶äºº: Qu, Jim æ??é??: amd-gfx list 主é¢?: Re: [PATCH] drm/amdgpu: atombios stuck executing during S3 stress test On Wed, Oct 19, 2016 at 4:25 AM, jimqu <Jim.Qu at amd.com> wrote: > Sometimes, atombios may be stucked when resume back. Duo to PCIE has > set to D3cold, the ACC of GFX adapter is power-down. it should re-init > the scratch registers. with the change, test is pass more than 80 cycles > on Fiji. > > Change-Id: I9cf40c475c4a5a31216949d50cc5e30b74dc21c4 > Signed-off-by: JimQu <Jim.Qu at amd.com> I think we probably want to save/restore these, although this shouldn't hurt. How about this patch? Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index e82c487..bfe9a5c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -2098,6 +2098,7 @@ int amdgpu_device_resume(struct drm_device *dev, bool resume, bool fbcon) > console_unlock(); > return r; > } > + amdgpu_atombios_scratch_regs_init(adev); > } > > /* post card */ > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx