> -----Original Message----- > From: Quan, Evan > Sent: Thursday, October 13, 2016 8:59 PM > To: Alex Deucher > Cc: Deucher, Alexander; amd-gfx at lists.freedesktop.org; Zhang, Jerry; Huan, > Alvin; Huang, Ray > Subject: RE: drm/amd/powerplay: expose max engine and memory clock > info for powerplay enabled case > > Hi Alex, > > > We can use amdgpu_dpm_get_sclk() and amdgpu_dpm_get_mclk() for > both powerplay and non-powerplay. No need to special case it. > Tested. It seems so. Updated the patch accordingly. Please have a check. Reviewed-by: Alex Deucher <alexander.deucher at amd.com> > > Regards, > Evan > > -----Original Message----- > From: Alex Deucher [mailto:alexdeucher at gmail.com] > Sent: Friday, October 14, 2016 5:52 AM > To: Quan, Evan <Evan.Quan at amd.com> > Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; amd- > gfx at lists.freedesktop.org; Zhang, Jerry <Jerry.Zhang at amd.com>; Huan, > Alvin <Alvin.Huan at amd.com>; Huang, Ray <Ray.Huang at amd.com> > Subject: Re: drm/amd/powerplay: expose max engine and memory clock > info for powerplay enabled case > > On Thu, Oct 13, 2016 at 4:24 AM, Quan, Evan <Evan.Quan at amd.com> wrote: > > Hi Alex, > > > > > > > > Thanks for your information. > > > > I updated the patch using the amdgpu_dpm_get_sclk/mclk APIs which > make > > the patch much simpler. > > > > > > We can use amdgpu_dpm_get_sclk() and amdgpu_dpm_get_mclk() for both > powerplay and non-powerplay. No need to special case it. > > Alex > > > > > Regards, > > > > Evan > > > > > > > > From: Deucher, Alexander > > Sent: Thursday, October 13, 2016 6:04 AM > > To: Quan, Evan <Evan.Quan at amd.com>; amd-gfx at lists.freedesktop.org > > Cc: Zhang, Jerry <Jerry.Zhang at amd.com>; Huan, Alvin > > <Alvin.Huan at amd.com>; Quan, Evan <Evan.Quan at amd.com>; Huang, Ray > > <Ray.Huang at amd.com> > > Subject: RE: drm/amd/powerplay: expose max engine and memory clock > > info for powerplay enabled case > > > > > > > > I don't know if we need to add a cgs call to fill in the > > max_clock_voltage_limits structure. That's mostly just leftover from > > radeon. A better solution would be use the existing > > amdgpu_dpm_get_sclk and amdgpu_dpm_get_mclk macros. Maybe > something > > like the attached patch? Unless there is a specific need for the max > > clocks on AC. I think in most cases the results will be the same. > > > > > > > > Alex > > > > > > > > From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf > > Of Quan, Evan > > Sent: Wednesday, October 12, 2016 1:53 AM > > To: amd-gfx at lists.freedesktop.org > > Cc: Zhang, Jerry; Huan, Alvin; Quan, Evan; Huang, Ray > > Subject: drm/amd/powerplay: expose max engine and memory clock info > > for powerplay enabled case > > > > > > > > Hi All, > > > > > > > > We found the max engine clock and max memory clock are both wrongly > > reported as 0(by AMDGPU_INFO_DEV_INFO ioctl). > > > > The attached patch tries to fix it. > > > > Please help to review it. > > > > Any comment is welcomed. > > > > > > > > Regards, > > > > Evan > > > > > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx at lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > >
